Polish attendance index (Sourcery refactored) #501
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![sourcery-ai[bot]](https://avatars.githubusercontent.com/in/48477?s=60&v=4){kind=small}
sourcery-ai
bot
force-pushed
the
sourcery/polish-attendance-index
branch
from
6020827
to
bb1abd9
Compare
sourcery-ai
bot
force-pushed
the
sourcery/polish-attendance-index
branch
from
bb1abd9
to
3e1c1b6
Compare
Comment on lines
-43
to
+47
| if int(formatted_amount) == formatted_amount: | ||
| return int(formatted_amount) | ||
| else: | ||
| return formatted_amount | ||
| return ( | ||
| int(formatted_amount) | ||
| if int(formatted_amount) == formatted_amount | ||
| else formatted_amount | ||
| ) |
There was a problem hiding this comment.
Function formatted_amount refactored with the following changes:
- Split conditional into multiple branches [×2] (
split-or-ifs) - Merge duplicate blocks in conditional [×2] (
merge-duplicate-blocks) - Replace if statement with if expression (
assign-if-exp) - Remove redundant conditional [×4] (
remove-redundant-if) - Replace multiple comparisons of same variable with
inoperator [×2] (merge-comparisons)
app/models/events.py
Outdated
Comment on lines
105
to
108
| relative_portion_count = 0 | ||
|
|
||
| # count portions of attendees with their portion size | ||
| for attendee in self.attendees: | ||
| relative_portion_count += getattr(attendee.portion_type, "size", 1) | ||
|
|
||
| relative_portion_count = sum( | ||
| getattr(attendee.portion_type, "size", 1) | ||
| for attendee in self.attendees | ||
| ) |
There was a problem hiding this comment.
Function Event.relative_portion_count refactored with the following changes:
- Convert for loop into call to sum() (
sum-comprehension)
This removes the following comments ( why? ):
# count portions of attendees with their portion size
| for i, recipe in enumerate(daily_recipes): | ||
| if recipe.is_shopping: | ||
| shopping_indexes.append(i) | ||
|
|
||
| shopping_indexes.extend( | ||
| i for i, recipe in enumerate(daily_recipes) if recipe.is_shopping | ||
| ) |
There was a problem hiding this comment.
Function Event.daily_recipes_split_by_shopping refactored with the following changes:
- Replace a for append loop with list extend (
for-append-to-extend)
Comment on lines
-211
to
+208
| return sum([t.count for t in self.event_portion_types]) | ||
| return sum(t.count for t in self.event_portion_types) |
There was a problem hiding this comment.
Function Event.people_with_any_portion_type_count refactored with the following changes:
- Replace unneeded comprehension with generator (
comprehension-to-generator)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request #500 refactored by Sourcery.
If you're happy with these changes, merge this Pull Request using the Squash and merge strategy.
NOTE: As code is pushed to the original Pull Request, Sourcery will
re-run and update (force-push) this Pull Request with new refactorings as
necessary. If Sourcery finds no refactorings at any point, this Pull Request
will be closed automatically.
See our documentation here.
Run Sourcery locally
Reduce the feedback loop during development by using the Sourcery editor plugin:
Review changes via command line
To manually merge these changes, make sure you're on the
polish-attendance-indexbranch, then run:Help us improve this pull request!