Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compile in Linux without changing the pom.xml #220

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

enexusde
Copy link

See in-line comment.

build this Project you need to change the hard-coded javadoc.exe.  The
executable can be overwritten using the -Djavadoc.executable.path
cli-parameter.  In example
-Djavadoc.executable.path=/home/example/jdk/bin/javadoc.
@Geolykt
Copy link
Contributor

Geolykt commented May 31, 2024

The better question really is - why is that line there in the first place? I've always removed it outright whenever I wanted or needed to compile janino from source and it seems to work. Plus, this configuration will not even work on almost all windows setups as the path is extremely specific; using something like ${java.home}/bin/javac.exe would be less specific, but would mean you'd loose control over which JDK is enacting the task. Since javadoc-maven-plugin 2.5 we could even use ${java.home}/bin and make it work on both linux and windows.

This PR would be related to following commit - unfortunately nothing can be learned from that change as it remains vague in nature:

TL;DR: I propose that we either drop the explicit definition of the javadoc executable altogether or to use ${java.home}/bin as the default. One would then easily be able to override that using their user-wide maven-settings.xml if need be (without committing this user-specific configuration to the whole world).

@enexusde
Copy link
Author

I do not insist. It reveals the PC's condition and environment (root-access, filestructure and operation-system) but I do not think a hacker could abuse that information. Feel free to do a review and add your suggestions.

@Geolykt
Copy link
Contributor

Geolykt commented May 31, 2024

What exactly do you mean with that? Especially the PC's condition and environment aspect I don't quite understand.

@enexusde
Copy link
Author

Forget about it.

@aunkrig
Copy link
Member

aunkrig commented Jun 1, 2024

I probably set the javadocExecutable to enforce that the Javadoc is generated with JDK 1.8, i.e. in Javadoc 1.8 style with frames and stuff.
But certainly it's ugly to have an absolute path in the POM. It was a quick hack.
I’ll look into that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants