Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: isomer-jekyll update #6

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Conversation

gweiying
Copy link

@gweiying gweiying commented Apr 5, 2021

This PR should be merged only when we migrate to Jekyll 4.

This PR updates isomer-tooling to include changes introduced by Isomer Jekyll gem link.

The changes introduced are also added to

  • isomer-tooling [here]
  • isomer-conversion-scripts link
  • isomerpages-template link
  • site-creation-backend link

Specifically, the changes are:

  • delete netlify.toml as we will no longer update netlify.toml via isomer-tooling
  • delete .ruby-version from repo as we will no longer update .ruby-version via isomer-tooling
  • delete Gemfile.lock from repo as we will no longer update Gemfile.lock via isomer-tooling
  • modify Gemfile to install isomer-jekyll gem
  • modify .gitignore to include .jekyll-cache (for Jekyll 4.0)

@gweiying gweiying changed the title feat: update standard_files for isomer-jekyll gem feat: isomer-jekyll update Apr 5, 2021
@gweiying gweiying marked this pull request as ready for review April 5, 2021 05:35
Copy link
Contributor

@prestonlimlianjie prestonlimlianjie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants