Refactor inertia share to use instance variables #111
Conversation
Move code to InertiaRails::Controller and use `class_attribute` to manage definitions without affecting parent controller. This avoids resetting shared data (`InertiaRails.reset!`) on every request. Instead, the shared data is defined at class loading. This change is thread-safe by design, so the multi-threading-test is removed.
|
wow that was fast |
|
@bknoles i see the problem with class_attribute and i refactor with this idea in mind: #108 (comment). Basically using instance attributes and |
PedroAugustoRamalhoDuarte
changed the title
|
Want to review the code a bit more, but, as I mentioned in #115 , I'm leaning towards merging this! |
|
The tests that are failling in CI are bit flaky, i dont know if is a error in the test code or in the new controller implementation i can check better in this friday |
|
Great addition! Refactoring to stick with default Rails conventions by using instance variables to store |
There was a problem hiding this comment.
This looks good to me! I asked for a couple small changes plus to revert the multithreaded spec back to its original state (so we aren't changing the implementation and the spec at the same time).
Once we get those hammered out I'll get this merged in! Thanks for the good work and the patience + persistence!
Team support! I like it! 😀 |
|
Released as part of |
Goal
This PR refactors how
inertia_shareis storage inside the request lifecycle.Solution
The solution was to sticky with default rails conventions, using only instance variable to storage inertia_share data and using inertia_share as a wrapper to rails before_action
Future improves
only,expectfeatures from before_action.