attempt to handle --version even in untagged builds #161
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I would love that! There are so many tools with the frustrating "Dev" version |
ccoVeille
reviewed
Jul 10, 2024
n-oden
force-pushed
the
version-handling
branch
2 times, most recently
from
7e5562f
to
a435082
Compare
ccoVeille
approved these changes
Jul 12, 2024
n-oden
force-pushed
the
version-handling
branch
2 times, most recently
from
54fb92f
to
5bd9ccc
Compare
ccoVeille
reviewed
Jul 12, 2024
ccoVeille
reviewed
Jul 12, 2024
If we are installed via `go-install` rather than downloading a tagged binary from github, the `Tag` etc variables will all be empty, and therefore the `--version` flag is diked out. But there is a way around this! If the version info is not filled in via build-time flags, use `debug.BuildInfo` to introspect as much information as we can out of the module metadata: ``` $ go install github.com/odenio/goimports-reviser/v3@v3.6.6-pre5 go: downloading github.com/odenio/goimports-reviser/v3 v3.6.6-pre5 $ ~/go/bin/goimports-reviser --version version: 3.6.6-pre5 built with: go1.22.4 tag: v3.6.6-pre5 commit: n/a source: github.com/odenio/goimports-reviser/v3 ``` Additionally, add a `--version-only` flag that prints only the version string itself, handy for use in shell pipelines. Can be used on its own or in combination with the `--version` flag: ``` $ ./go/bin/goimports-reviser --version-only 3.6.6-pre5 ```
ccoVeille
approved these changes
Jul 14, 2024
|
Thanks for the approval! Can someone merge this? I cannot. |
|
I'm a random Gopher. You will have to wait for a maintainer review |
|
For the record if anyone would like to kick the tires on this, #160 and #159, I've made a build containing all three patches available as I don't intend to maintain a long-lived fork here, but I understand that the maintainer may have bigger fish to fry at the moment, residing in Ukraine. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This addresses #155
If we are installed via
go-installrather than downloading a tagged binary from github, theTagetc variables will all be empty, and therefore the--versionflag is diked out. But there is a way around this!If the version info is not filled in via build-time flags, use
debug.BuildInfoto introspect as much information as we can out of the module metadata:Additionally, add a
--version-onlyflag that prints only the version string itself, handy for use in shell pipelines. Can be used on its own or in combination with the--versionflag: