Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reworked check_timing to provide a structured error report #200

Open
wants to merge 10 commits into
base: dev
Choose a base branch
from

Commits on Sep 2, 2024

  1. Configuration menu
    Copy the full SHA
    78350dd View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    1e70419 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    089cb3c View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    3966e4b View commit details
    Browse the repository at this point in the history
  5. Removed silent adjustment of ADC delay to ADC dead time

    (This should be caught by `make_adc`. If we get here, the user really wants to adjust the delay and just accept it and let `check_timing` report it)
    FrankZijlstra committed Sep 2, 2024
    Configuration menu
    Copy the full SHA
    4309ba2 View commit details
    Browse the repository at this point in the history
  6. Reworked check_timing to provide a structured error report

    - Added unit test for `check_timing`
    - The default signature of `seq.check_timing` remains the same, but can pretty-print the report with `print_errors=True`
    - `seq.write` now checks sequence timing by default
    - 'TotalDuration' calculation moved from `check_timing` to `seq.write`
    - Check whether gradients in the last block ramp down to zero removed from `check_timing`
    FrankZijlstra committed Sep 2, 2024
    Configuration menu
    Copy the full SHA
    bca60f4 View commit details
    Browse the repository at this point in the history
  7. Added optional tracing of where blocks/events were created

    - Can be enabled/disabled with `pp.enable_trace(limit)` and `pp.disable_trace()`
    - Added tracing to all blocks and all RF/ADC/gradient events
    - Added printing of the trace to `check_timing` when it is available
    FrankZijlstra committed Sep 2, 2024
    Configuration menu
    Copy the full SHA
    aef87e7 View commit details
    Browse the repository at this point in the history
  8. Configuration menu
    Copy the full SHA
    92daf61 View commit details
    Browse the repository at this point in the history
  9. Updated expected output for test_sequence because it did not includ…

    …e `TotalDuration` in the sequence definitions
    FrankZijlstra committed Sep 2, 2024
    Configuration menu
    Copy the full SHA
    0ce14be View commit details
    Browse the repository at this point in the history

Commits on Sep 5, 2024

  1. Fixed continuity checks for arbitrary gradients

    - `Sequence.write` now checks whether the last block ramps down to 0
    - Fixed gradient continuity checks in `set_block`
      - Now handles arbitrary block orders properly
      - Now properly checks the last value of the previous block
      - Added gradient checks for blocks without gradients
      - Sequence object now remains valid after gradient errors
    - Added unit tests for gradient continuity in `test_block`
    FrankZijlstra committed Sep 5, 2024
    Configuration menu
    Copy the full SHA
    3d27a05 View commit details
    Browse the repository at this point in the history