Bugfix/chart memory leak #1692
Merged
Bugfix/chart memory leak #1692
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… in the lineChart, it caused some memory issues, we will remove the caching for now, but later we have to move the calculations into the renderers to keep and update the values when the data changes, #1106
…hart, it caused some memory issues, we will remove the caching for now, but later we have to move the calculations into the renderers to keep and update the values when the data changes, #1106
… in the scatterChart, it caused some memory issues, we will remove the caching for now, but later we have to move the calculations into the renderers to keep and update the values when the data changes, #1106
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1106
As we don't have any quick solution to fix the issue, I will disable the caching for now. The trade off is that we need to calculate the min, max values based on the data (if it is not provided) in every frame.
I wrote in the documentation that it is more performant if you provide these parameters.
Btw, for the final fix (resolve the performance issue if you haven't provided the parameters), we need to move the calculation logic into the renderer objects as they remain in the memory as long as widget exists. So this way, we don't need to calculate the values in every frame. We just keep and calculate them once the data is changed in the renderer objects that we have.