Sysdetect: fix snprintf behavior #42
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gcongiu
changed the title
gcongiu
force-pushed
the
2023.07.06_sysdetect-snprintf-fix
branch
from
a20c0e3
to
30c3c90
Compare
gcongiu
changed the title
gcongiu
changed the title
gcongiu
force-pushed
the
2023.07.06_sysdetect-snprintf-fix
branch
from
f490b07
to
7d12543
Compare
gcongiu
force-pushed
the
2023.07.06_sysdetect-snprintf-fix
branch
from
7d12543
to
b3503ba
Compare
|
@jagode can you approve? |
snprintf will always null terminate the output string regarless characters from input string being dropped (i.e. if the output string is shorter than the input string).
snprintf will always null terminate the output string regarless characters from input string being dropped (i.e. if the output string is shorter than the input string).
The n argument in snprintf specifies the length of the output string not the one of the input string.
The n argument in snprintf specifies the length of the output string not the one of the input string.
gcongiu
force-pushed
the
2023.07.06_sysdetect-snprintf-fix
branch
from
b3503ba
to
f77f787
Compare
adanalis
approved these changes
Sep 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Description
The
sysdetectcomponent makes a wrong usage ofsnprintf. In a few instances,snprintfis used to copy a string of size X to a string of sizePAPI_MAX_STR_LEN. However, thesysdetectcode sets thenargument ofsnprintf, indicating the target string length, to the length of the source string (i.e., X). Additionally, sometimes the code null-terminates the target string, which is not necessary becausesnprintfalways null-terminates the target string.Author Checklist
Why this PR exists. Reference all relevant information, including background, issues, test failures, etc
Commits are self contained and only do one thing
Commits have a header of the form:
module: short descriptionCommits have a body (whenever relevant) containing a detailed description of the addressed problem and its solution
The PR needs to pass all the tests