Sde shutdown #41
Merged
Sde shutdown #41
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adanalis
force-pushed
the
sde_shutdown
branch
2 times, most recently
from
97d74fd
to
058c16e
Compare
gcongiu
approved these changes
Jun 30, 2023
gcongiu
reviewed
Jul 3, 2023
adanalis
force-pushed
the
sde_shutdown
branch
2 times, most recently
from
8a9fa16
to
9844e0f
Compare
This function helps abstract the hash-table from other parts of the code, instead of directly accessing the internal structure of the hash table from all over the place.
Protected reading funtion with locks so it can't race against papi_sde_shutdown().
Counters can belong in groups, even multiple groups, and groups can recursively belong in larger groups. This means that a counter (or group) cannot be unregistered and freed without keep track of which groups it belong to. Now each counter has a reference counter "ref_count" which is incremented when it's added in a group and decremented when the counter is unregistered, or when a parent group is unregistered.
If reading a group has been requested from the application/tool layer (though PAPI_event_name_to_code()) before the group is actually registered by the library, we will create a placeholder for it. This change allows the group registration to overwrite the placeholder.
If the item being deleted from the hash-table happened to be on the head of a list and there was no other item in the list, then the head was not being cleaned properly.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the code that unregisters counters in the presence of groups. The basic idea behind the change is adding a reference count to each counter so we can keep track of the number of groups it belongs to. In the process of fixing this, I also abstracted the use of the hash-tables a bit, so we don't access their internal structure from multiple places in the code, and added some locking to prevent race conditions between reading and shutdown.