rocm: user HIP_ROOT for hipcc compiler in tests Makefile #35
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gcongiu
force-pushed
the
2023.06.28_rocm-tests-fix
branch
2 times, most recently
from
b6af622
to
e0cf3f3
Compare
gcongiu
force-pushed
the
2023.06.28_rocm-tests-fix
branch
2 times, most recently
from
35950c4
to
8cef65e
Compare
jagode
approved these changes
Jul 3, 2023
The rocm tests assume hipcc is located under the same root directory as the rest of rocm toolkit software. Spack installs rocm dependencies in separate directories however, which breaks this assumption. This patch introduces a HIP_PATH variable that, if unset, is set automatically to PAPI_ROCM_ROOT. Spack can use this variable to let the tests Makefile in the PAPI rocm component know where the hipcc compiler is located.
gcongiu
force-pushed
the
2023.06.28_rocm-tests-fix
branch
from
8cef65e
to
eb23fff
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The rocm tests assume hipcc is located under the same root directory as the rest of rocm toolkit software. Spack installs rocm dependencies in separate directories however, which breaks this assumption. This patch introduces a HIP_ROOT variable that, if unset, is set automatically to PAPI_ROCM_ROOT/hip. Spack can use this variable to let the tests Makefile in the PAPI rocm component know where the hipcc compiler is located.