rocm_smi: rename special cases to derived events #33
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gcongiu
force-pushed
the
2023.03.27_rocm-smi-name-refactor
branch
2 times, most recently
from
da55496
to
9eeef59
Compare
Treece-Burgess
force-pushed
the
2023.03.27_rocm-smi-name-refactor
branch
from
9eeef59
to
d6c60a5
Compare
|
@adanalis This looks good to me, I tested locally as well with everything appearing to behave as expected. I will rebase one last time before merging if it looks good to you as well. |
Treece-Burgess
approved these changes
Oct 1, 2024
Derived events are handled in the `handle_special_events` function. This name is not intuitive. Use `handle_derived_events` instead.
Treece-Burgess
force-pushed
the
2023.03.27_rocm-smi-name-refactor
branch
from
d6c60a5
to
e561313
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Derived events are handled in the
handle_special_eventsfunction. This name is not intuitive. Use the more descriptivehandle_derived_eventsinstead.