Cuda component fixes #209
Merged
Cuda component fixes #209
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Using a "%s" format in the sprintf to avoid the following error when
compiling the cuda component with -Werror=format-security :
components/cuda/linux-cuda.c: In function ‘cuda_init_private’:
components/cuda/linux-cuda.c:158:9: error: format not a string literal and no format arguments [-Werror=format-security]
158 | sprintf(_cuda_vector.cmp_info.disabled_reason, disabled_reason);
| ^~~~~~~
cc1: some warnings being treated as errors
…eing used A check in the Makefile for the cuda tests assumed the nvcc found on $PATH and the one referred to by $(NVCC) were the same. It is possible to have multiple versions of cuda installed on the system and the one being used for $(NVCC) may not be the same as the one found on the default path. Should always be use $(NVCC) in the Makefile to ensure getting the same version of nvcc.
jagode
approved these changes
Jul 29, 2024
jagode
approved these changes
Jul 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Description
When working through and trying to build locally build a PAPI RPM with the cuda component enabled, I found a couple minor issues in the cuda component that prevented it from being built:
When runing "run_tests.sh" the ctests/all_native_events: took a number of hours to complete, but the tests eventually completed.
Author Checklist
Why this PR exists. Reference all relevant information, including background, issues, test failures, etc
Commits are self contained and only do one thing
Commits have a header of the form:
module: short descriptionCommits have a body (whenever relevant) containing a detailed description of the addressed problem and its solution
The PR needs to pass all the tests