Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enhance hyper link menu code, so now it can access and work for more … #11

Merged
merged 1 commit into from
Jan 26, 2024

Conversation

ibrahim-s
Copy link
Owner

Hi @cary-rowen
This pull request is an enhancement to the old hyper link menu code,
for a lot of times in some pages like facebook for instance, the old code fails to get the destination of the link, and subsequently menu does not open.
Really the code in NVDA core, has been enhanced and changed, and I have made use of that and used the new code to get the destination of the link, and by testing I find it now better, and more links can be accessed and opened with hyper link menu.
Hope to get your review and opinion.

@cary-rowen
Copy link
Collaborator

Hi @ibrahim-s
Nice improvement, looks good to me.

@ibrahim-s
Copy link
Owner Author

@cary-rowen
Thank you dear Cary
and I feel this addon is useful and could be on NVDA store
what do you think
regards

@cary-rowen
Copy link
Collaborator

Yes, I totally agree.

@ibrahim-s
Copy link
Owner Author

OK, @cary-rowen
I will try to make a stable version for NVDA 2023.3, and submit it to the store, and see.

Thanks for your activity for NVDA, and being a partner in this addon
kind regards

@ibrahim-s ibrahim-s merged commit 68fd5f6 into master Jan 26, 2024
2 checks passed
@cary-rowen
Copy link
Collaborator

Thanks for your efforts and I look forward to seeing it in NVDA add-on store.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants