Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: repo homepage latest commit hovercard openrank display #846

Merged
merged 2 commits into from
Jul 27, 2024

Conversation

Tenth-crew
Copy link
Collaborator

@Tenth-crew Tenth-crew commented Jul 25, 2024

Brief Information

This pull request is in the type of (more info about types):

  • build
  • ci
  • docs
  • feat
  • fix
  • perf
  • refactor
  • test

Related issues #842

  • keyword #xxx

Details

QQ_1721891276737

Checklist

Others

Thanks to Yantong's help, OpenRank can now be displayed normally in most scenarios.

try {
await elementReadyWithTimeout('[data-testid=github-avatar]', { stopOnDomReady: false }, 1500);
} catch (error) {
console.error(error);
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it necessary to output error messages here?

@wangyantong2000
Copy link
Collaborator

Why does the function sometimes load twice. Does @wxharry know the reason?

@wxharry
Copy link
Collaborator

wxharry commented Jul 26, 2024

Why does the function sometimes load twice. Does @wxharry know the reason?

Do you know how to replicate the issue? I thought it was handled by the previous PR

@wangyantong2000
Copy link
Collaborator

image image

This feature sometimes occurs when entering a repository, and it is loaded twice.
Like this.

@wxharry
Copy link
Collaborator

wxharry commented Jul 27, 2024

image

It is loaded twice, never seen this before. Weird.

@wxharry wxharry merged commit 793fb40 into hypertrons:master Jul 27, 2024
2 checks passed
@wxharry
Copy link
Collaborator

wxharry commented Jul 27, 2024

Sorry, I don't what happened, I merged this branch. I just reverted you changes back, but this PR is closed, could you make an other PR and mention this one? Sorry for the inconvenience and thank you so much!

@Tenth-crew
Copy link
Collaborator Author

Sorry, I don't what happened, I merged this branch. I just reverted you changes back, but this PR is closed, could you make an other PR and mention this one? Sorry for the inconvenience and thank you so much!

OK, I'll resubmit the PR later.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants