Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fix action trigger button #844

Merged

Conversation

wangyantong2000
Copy link
Collaborator

@wangyantong2000 wangyantong2000 commented Jul 25, 2024

Brief Information

This pull request is in the type of (more info about types):

  • build
  • ci
  • docs
  • feat
  • fix
  • perf
  • refactor
  • test

Related issues (all available keywords):

#825
#832

Details

Fixed the issue of GitHub action trigger button not displaying.

iShot_2024-07-25_10.28.07.mp4

Changed the style in #832 to better match the native style on GitHub.
image

Checklist

Others

@andyhuang18
Copy link
Collaborator

If we want to promote OpenRank, would it be better to highlight it, such as in bold?

@wangyantong2000
Copy link
Collaborator Author

If we want to promote OpenRank, would it be better to highlight it, such as in bold?

This is a point that can be considered. How do others consider it?

@andyhuang18
Copy link
Collaborator

andyhuang18 commented Jul 25, 2024

Refer to the official highlight mode of GitHub, you can change the color or use underline or bold.

image

@wangyantong2000 wangyantong2000 merged commit 702fcbd into hypertrons:master Jul 25, 2024
2 checks passed
Copy link
Collaborator

@andyhuang18 andyhuang18 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wangyantong2000
Copy link
Collaborator Author

Refer to the official highlight mode of GitHub, you can change the color or use underline or bold.

image

This issue is not the main concern of this PR. Afterwards, a separate issue will be opened to discuss the style issue of OpenRank.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants