[OSS101] Task 5: Display Community OpenRank #843
Conversation
add colorful canlendar
add community openrank api and feature container
feat: Add Community OpenRank Detail Network
add Community OpenRank Racing Bar
|
Would it be better to compare similar items in racing bar, such as comparing people to people, comparing PR to PR, and so on. Perhaps a selection box can be added to choose between different categories, or in other ways. |
|
Hi~@Fiveneves Thank you for your detailed work. You provided rich pictures and detailed descriptions. From your commit flow, it can be seen that you take this task seriously. |
Okay, I'll try to change it |
remove colorful calendar feature
| td { | ||
| border: 1px solid black; | ||
| text-align: center; /* 水平居中 */ | ||
| vertical-align: middle; /* 垂直居中 */ |
There was a problem hiding this comment.
It is best to replace the Chinese comments in the code with English.
| // lastDataAvailableMonth.setDate(0); | ||
| // | ||
| // const newestMonth = | ||
| // lastDataAvailableMonth.getFullYear() + '-' + (lastDataAvailableMonth.getMonth() + 1).toString().padStart(2, '0'); |
There was a problem hiding this comment.
Necessary comments can be retained. Similar to some code that has been commented out, it can be deleted if it is no longer used.
| import DataNotFound from '../repo-networks/DataNotFound'; | ||
| import { CommunityOpenRankDetails } from './data'; | ||
| import { JsonObject } from 'type-fest'; | ||
|
|
There was a problem hiding this comment.
Some imported items are not used in the subsequent code, and similar situations in the code can be removed.
There was a problem hiding this comment.
@wangyantong2000 Thanks for the detailed review. ❤️
|
|
Fix a Bug in sorting data
…e different categories for comparison
Implement the function of selecting different categories of items for comparison in the CommunityOpenRankRacingBar feature
|
@wangyantong2000 Hi~All the problems mentioned above have been resolved, and the final look as shown in the demo gif below. |
|
Sorry for not replying to this PR for a long time. This task was completed very well. The task is to design and develop features related to Community OpenRank. The final form you presented is good. Just because the previous similar function was to directly request the obtained data. And the data for this feature was not directly provided. You organize the relevant data by yourself, and there may be situations where there is no data according to the default dates set in the code, such as some new warehouses. So this PR may not be merged into the main repository temporarily. But this is due to data level issues, which does not prevent it from being a good final assignment. You have successfully and well completed this assignment. |
If there are some cases that data is not provided, we should handle it properly in this feature. This feature is supposed to be independant. |
Brief Information
This pull request is in the type of (more info about types):
Related issues (all available keywords):
Details
Add two features of the community OpenRank network and the community OpenRank racing bar to the perceptor page.
Checklist
Others
N.A.