feat(iroha-connector): add prometheus exporter to the plugin #3461
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ashnashahgrover
requested review from
petermetz,
takeutak,
izuru0,
jagpreetsinghsasan,
VRamakrishna,
sandeepnRES and
outSH
as code owners
ashnashahgrover
changed the title
ashnashahgrover
force-pushed
the
ashnashahgrover/issue1260
branch
from
8a9e656
to
901cab4
Compare
ashnashahgrover
changed the title
jagpreetsinghsasan
requested changes
Aug 6, 2024
...tegration/plugin-ledger-connector-besu/deploy-contract/v21-deploy-contract-from-json.test.ts
Outdated
Show resolved
Hide resolved
...tegration/plugin-ledger-connector-besu/deploy-contract/v21-deploy-contract-from-json.test.ts
Outdated
Show resolved
Hide resolved
...cactus-plugin-ledger-connector-iroha2/src/main/typescript/cactus-iroha-sdk-wrapper/client.ts
Outdated
Show resolved
Hide resolved
.../cactus-plugin-ledger-connector-iroha2/src/main/typescript/plugin-ledger-connector-iroha2.ts
Outdated
Show resolved
Hide resolved
.../cactus-plugin-ledger-connector-iroha2/src/main/typescript/plugin-ledger-connector-iroha2.ts
Outdated
Show resolved
Hide resolved
...r-connector-iroha2/src/test/typescript/integration/iroha2-setup-and-basic-operations.test.ts
Outdated
Show resolved
Hide resolved
ashnashahgrover
force-pushed
the
ashnashahgrover/issue1260
branch
3 times, most recently
from
d12876e
to
44b7c44
Compare
|
@jagpreetsinghsasan Have addressed all requested changes. |
petermetz
requested changes
Aug 9, 2024
There was a problem hiding this comment.
@ashnashahgrover LGTM with comments (mostly just nit-picks)
...ector-iroha2/src/main/typescript/web-services/get-prometheus-exporter-metrics-endpoint-v1.ts
Outdated
Show resolved
Hide resolved
.../cactus-plugin-ledger-connector-iroha2/src/main/typescript/plugin-ledger-connector-iroha2.ts
Outdated
Show resolved
Hide resolved
ashnashahgrover
force-pushed
the
ashnashahgrover/issue1260
branch
from
44b7c44
to
ea7557d
Compare
Have addressed all the requests. |
petermetz
approved these changes
Aug 12, 2024
outSH
requested changes
Aug 13, 2024
...r-iroha2/src/test/typescript/integration/iroha2-generate-and-send-signed-transaction.test.ts
Outdated
Show resolved
Hide resolved
...cactus-plugin-ledger-connector-iroha2/src/main/typescript/cactus-iroha-sdk-wrapper/client.ts
Outdated
Show resolved
Hide resolved
ashnashahgrover
force-pushed
the
ashnashahgrover/issue1260
branch
from
ea7557d
to
4740710
Compare
outSH
approved these changes
Aug 16, 2024
ashnashahgrover
force-pushed
the
ashnashahgrover/issue1260
branch
from
4740710
to
c60fe15
Compare
ashnashahgrover
force-pushed
the
ashnashahgrover/issue1260
branch
2 times, most recently
from
fe6f61f
to
0aa2d50
Compare
Primary Changes ---------------- 1. Added Prometheus Exporter to Iroha ledger plugin 2. Added Prometheus Metrics tracker to relevant iroha tests. Fixes hyperledger#1260 Signed-off-by: ashnashahgrover <as19@williams.edu>
ashnashahgrover
force-pushed
the
ashnashahgrover/issue1260
branch
from
0aa2d50
to
d2b3c64
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Commit to be reviewed
feat(iroha-connector): add prometheus exporter to the plugin
Fixes #1260
Pull Request Requirements
upstream/mainbranch and squashed into single commit to help maintainers review it more efficient and to avoid spaghetti git commit graphs that obfuscate which commit did exactly what change, when and, why.-sflag when usinggit commitcommand. You may refer to this link for more information.Character Limit
A Must Read for Beginners
For rebasing and squashing, here's a must read guide for beginners.