Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(tcs-huawei-socketio): remove deprecated connector #3342

Merged
merged 1 commit into from
Aug 8, 2024

Conversation

outSH
Copy link
Contributor

@outSH outSH commented Jun 20, 2024

  • Remove cactus-plugin-ledger-connector-tcs-huawei-socketio connector and any reference to it.
  • This is not permanent - we'd love to bring the package back once the necessary refactors are done!
  • See issue chore(plugins): remove deprecated packages #3155 on github for more details on context and reasoning of this decision.

Part of #3155

Pull Request Requirements

  • Rebased onto upstream/main branch and squashed into single commit to help maintainers review it more efficient and to avoid spaghetti git commit graphs that obfuscate which commit did exactly what change, when and, why.
  • Have git sign off at the end of commit message to avoid being marked red. You can add -s flag when using git commit command. You may refer to this link for more information.
  • Follow the Commit Linting specification. You may refer to this link for more information.

Character Limit

  • Pull Request Title and Commit Subject must not exceed 72 characters (including spaces and special characters).
  • Commit Message per line must not exceed 80 characters (including spaces and special characters).

A Must Read for Beginners
For rebasing and squashing, here's a must read guide for beginners.

Copy link
Contributor

@izuru0 izuru0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@outSH outSH force-pushed the remove_tcs_huawei_socketio_pr branch from 7ba7298 to 4667962 Compare August 7, 2024 10:32
@outSH outSH enabled auto-merge (rebase) August 7, 2024 10:33
@petermetz petermetz force-pushed the remove_tcs_huawei_socketio_pr branch from 4667962 to 9f0a797 Compare August 8, 2024 01:51
@outSH outSH disabled auto-merge August 8, 2024 09:34
@outSH outSH enabled auto-merge (rebase) August 8, 2024 09:34
- Remove `cactus-plugin-ledger-connector-tcs-huawei-socketio` connector and
  any reference to it.
- This is not permanent - we'd love to bring the package back once the
    necessary refactors are done!
- See issue hyperledger#3155 on github for more details on context and reasoning
    of this decision.

Part of hyperledger#3155

Signed-off-by: Michal Bajer <michal.bajer@fujitsu.com>
@outSH outSH force-pushed the remove_tcs_huawei_socketio_pr branch from 9f0a797 to cc49525 Compare August 8, 2024 13:00
@outSH outSH merged commit 053224f into hyperledger:main Aug 8, 2024
141 of 142 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants