-
Notifications
You must be signed in to change notification settings - Fork 278
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test: fix all broken validations in packages folder #3493
Labels
bug
Something isn't working
Comments
This issue is a dependency of #3483 |
ashnashahgrover
added a commit
to ashnashahgrover/cacti
that referenced
this issue
Aug 26, 2024
Primary Changes --------------- 1. Fixed broken assertions in deploy-contract-from-json-xdai.test.ts so they assert that “Nonce is too low” as expected. Fixes hyperledger#3493 Signed-off-by: ashnashahgrover <ashnashahgrover777@gmail.com>
ashnashahgrover
added a commit
to ashnashahgrover/cacti
that referenced
this issue
Aug 27, 2024
Primary Changes --------------- 1. Fixed broken assertions in deploy-contract-from-json-xdai.test.ts so they assert that “Nonce is too low” as expected. Fixes hyperledger#3493 Signed-off-by: ashnashahgrover <ashnashahgrover777@gmail.com>
ashnashahgrover
added a commit
to ashnashahgrover/cacti
that referenced
this issue
Aug 27, 2024
Primary Changes --------------- 1. Fixed broken assertions in deploy-contract-from-json-xdai.test.ts so they assert that “Nonce is too low” as expected. Fixes hyperledger#3493 Signed-off-by: ashnashahgrover <ashnashahgrover777@gmail.com>
5 tasks
ashnashahgrover
added a commit
to ashnashahgrover/cacti
that referenced
this issue
Sep 3, 2024
Primary Changes --------------- 1. Fixed broken assertions in deploy-contract-from-json-xdai.test.ts so they assert that “Nonce is too low” as expected. Fixes hyperledger#3493 Signed-off-by: ashnashahgrover <as19@williams.com>
ashnashahgrover
added a commit
to ashnashahgrover/cacti
that referenced
this issue
Sep 3, 2024
Primary Changes --------------- 1. Fixed broken assertions in deploy-contract-from-json-xdai.test.ts so they assert that “Nonce is too low” as expected. Fixes hyperledger#3493 Signed-off-by: ashnashahgrover <ashnashahgrover777@gmail.com>
ashnashahgrover
added a commit
to ashnashahgrover/cacti
that referenced
this issue
Sep 3, 2024
Primary Changes --------------- 1. Fixed broken assertions in deploy-contract-from-json-xdai.test.ts so they assert that “Nonce is too low” as expected. Fixes hyperledger#3493 Signed-off-by: ashnashahgrover <ashnashahgrover777@gmail.com>
ashnashahgrover
added a commit
to ashnashahgrover/cacti
that referenced
this issue
Sep 21, 2024
Primary Changes --------------- 1. Fixed broken assertions in deploy-contract-from-json-xdai.test.ts so they assert that “Nonce is too low” as expected. Fixes hyperledger#3493 Signed-off-by: ashnashahgrover <ashnashahgrover777@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Describe the bug
Two tests are failing in the packages folder:
- From packages/cactus-plugin-ledger-connector-xdai/src/test/typescript/integration/deploy-contract-from-json-xdai.test.ts:
To Reproduce
Run these tests in run and debug and note the failing tests in the terminal output.
Expected behavior
The failing tests should pass - contingent upon the jest assertions in those tests also passing. If the test description says the specific function called should return an error, it should return an error and not a resolved promise.
The text was updated successfully, but these errors were encountered: