Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: refactor jest test negative test cases - phase 1 #3483

Open
ashnashahgrover opened this issue Aug 13, 2024 · 1 comment · May be fixed by #3488
Open

test: refactor jest test negative test cases - phase 1 #3483

ashnashahgrover opened this issue Aug 13, 2024 · 1 comment · May be fixed by #3488
Assignees
@ashnashahgrover
Labels
enhancement New feature or request

Comments

@ashnashahgrover
Copy link
Contributor

Refactor all the remaining negative test case exception assertions for all tests in cacti/packages so that they do not use try-catch blocks but instead declare the requirements through Jest's (and jest-extended's) own API.

The parent issue with a much more detailed explanation of what's needed and code examples on how to do it:
Parent Issue: #3455

Acceptance Criteria
Test passes the same as before
Negative test case assertions have been migrated the way it is explained in the parent issue.
@ashnashahgrover ashnashahgrover added the enhancement New feature or request label Aug 13, 2024
ashnashahgrover added a commit to ashnashahgrover/cacti that referenced this issue Aug 18, 2024
@ashnashahgrover
Primary Changes
ef05d0e 
---------------
1. Refactored all remaining negative test case exception assertions under cacti/packages
Removed try-catch blocks, replaced with declarations through jest-extended's own API.

Fixes hyperledger#3483

Signed-off-by: ashnashahgrover <ashnashahgrover777@gmail.com>
ashnashahgrover added a commit to ashnashahgrover/cacti that referenced this issue Aug 18, 2024
@ashnashahgrover
test: refactor jest test negative test cases - phase 1
947d28a 
Primary Changes
---------------
1. Refactored all remaining negative test case exception assertions under cacti/packages
Removed try-catch blocks, replaced with declarations through jest-extended's own API.

Fixes hyperledger#3483

Signed-off-by: ashnashahgrover <ashnashahgrover777@gmail.com>
@ashnashahgrover ashnashahgrover linked a pull request Aug 18, 2024 that will close this issue
Open
ashnashahgrover added a commit to ashnashahgrover/cacti that referenced this issue Aug 26, 2024
@ashnashahgrover
test: refactor jest test negative test cases - phase 1
44ebecf 
Primary Changes
---------------
1. Refactored all remaining negative test case exception assertions under cacti/packages
Removed try-catch blocks, replaced with declarations through jest-extended's own API.

Fixes hyperledger#3483

Signed-off-by: ashnashahgrover <ashnashahgrover777@gmail.com>
@ashnashahgrover
Copy link
Contributor Author

This issue is now dependent on this issue

3493

@ashnashahgrover ashnashahgrover mentioned this issue Aug 26, 2024
Open
ashnashahgrover added a commit to ashnashahgrover/cacti that referenced this issue Aug 26, 2024
@ashnashahgrover
test: refactor jest test negative test cases - phase 1
31c3426 
Primary Changes
---------------
1. Refactored all remaining negative test case exception assertions under cacti/packages
Removed try-catch blocks, replaced with declarations through jest-extended's own API.

Fixes hyperledger#3483

Signed-off-by: ashnashahgrover <ashnashahgrover777@gmail.com>
ashnashahgrover added a commit to ashnashahgrover/cacti that referenced this issue Sep 3, 2024
@ashnashahgrover
test: refactor jest test negative test cases - phase 1
deb0a86 
Primary Changes
---------------
1. Refactored all remaining negative test case exception assertions under cacti/packages
Removed try-catch blocks, replaced with declarations through jest-extended's own API.

Fixes hyperledger#3483

Signed-off-by: ashnashahgrover <ashnashahgrover777@gmail.com>
@ashnashahgrover ashnashahgrover mentioned this issue Sep 3, 2024
Open
5 tasks
ashnashahgrover added a commit to ashnashahgrover/cacti that referenced this issue Sep 21, 2024
@ashnashahgrover
test: refactor jest test negative test cases - phase 1
f2c27ea 
Primary Changes
---------------
1. Refactored all remaining negative test case exception assertions under cacti/packages
Removed try-catch blocks, replaced with declarations through jest-extended's own API.

Fixes hyperledger#3483

Signed-off-by: ashnashahgrover <ashnashahgrover777@gmail.com>
ashnashahgrover added a commit to ashnashahgrover/cacti that referenced this issue Sep 21, 2024
@ashnashahgrover
test: refactor jest test negative test cases - phase 1
69ce435 
Primary Changes
---------------
1. Refactored all remaining negative test case exception assertions under cacti/packages
Removed try-catch blocks, replaced with declarations through jest-extended's own API.

Fixes hyperledger#3483

Signed-off-by: ashnashahgrover <ashnashahgrover777@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ashnashahgrover ashnashahgrover

Labels
enhancement New feature or request
Projects
Cacti_Scrum_Project_v2_Release
Status: In review
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

test: refactor jest test negative test cases - phase 1 ashnashahgrover/cacti
1 participant
@ashnashahgrover