-
-
Notifications
You must be signed in to change notification settings - Fork 59
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
$mol_text: add spoilers support #693
Conversation
text/text/text.view.ts
Outdated
@ $mol_mem_key | ||
spoiler_label( index: number ): any { | ||
return this.Spoiler_label(index); | ||
} | ||
|
||
@ $mol_mem_key | ||
spoiler_content( index: number ): any { | ||
return this.Spoiler_content(index); | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
А это переименовывание зачем?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Показалось логичным такое именование. Есть метод возвращающий просто текст (spoiler_text
), есть методы, которые возвращают текст для конкретных частей спойлеров (например, spoiler_label_text
), ну и методы, возвращающие компонент с конкретной частью спойлера (например, spoiler_label
).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Тут же просто перекладывание из метода с болшой буквой в метод с маленькой.
No description provided.