mol_build: index.xml.tree support #599
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nin-jin
reviewed
Jun 10, 2023
build/build.node.ts
Outdated
| @@ -772,6 +772,8 @@ namespace $ { | |||
| @ $mol_action | |||
| bundleAll( { path } : { path : string } ) { | |||
|
|
|||
|
|
|||
| this.bundle({ path , bundle : 'index.xml.tree' }) | |||
There was a problem hiding this comment.
Это должно быть в index.html бандле.
There was a problem hiding this comment.
грубо говоря вынести это в одну функцию bundleIndexHtml?
There was a problem hiding this comment.
Ага, это же часть логики формирования index.html.
There was a problem hiding this comment.
я бы ещё оповещал, что мы не смотрим index.html при наличии index.xml.tree
There was a problem hiding this comment.
Может наоборот не смотреть на index.xml.tree или вообще сливать их?
nin-jin
reviewed
Jun 10, 2023
build/build.node.ts
Outdated
| @@ -772,6 +772,8 @@ namespace $ { | |||
| @ $mol_action | |||
| bundleAll( { path } : { path : string } ) { | |||
|
|
|||
|
|
|||
| this.bundle({ path , bundle : 'index.xml.tree' }) | |||
| this.bundle({ path , bundle : 'index.html' }) | |||
| this.bundle({ path , bundle : 'test.html' }) | |||
There was a problem hiding this comment.
И нужно убедиться, что этот бандл подхватывает генерируемый index.html.
nin-jin
approved these changes
Jun 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.