Fix offline mode not working in Chrome #275
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
LGTM, thanks for working on this, can you update the core submodule also? |
|
Done. A quick note is that the link I added in the doc is for Chrome, but I guess Edge users should understand? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #263 by making the "Allow access to file URLs" setting show. Tested to work in Chrome 123.0.6312.58.
This PR relies on huhu/search-extension-core#12 to be merged first and requires an update of the
coresubmodule afterwards. Thank you for your attention.Edit: I tried to test this on Edge but I wasn't allowed to enable the extension for security reasons. However, the "Allow access to file URLs" setting did show, so I guess it would work similarly.