Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Arg name correction: auth_token -> token #1621

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

rravenel
Copy link

Simple correction.

@HuggingFaceDocBuilderDev

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

Copy link
Member

@stevhliu stevhliu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

cc @ArthurZucker for a quick review (this fixes huggingface/transformers#33183)

Copy link
Collaborator

@ArthurZucker ArthurZucker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, actually you would need to modify the rust code that generate this init file!

@stevhliu
Copy link
Member

stevhliu commented Sep 3, 2024

Ah ok, sorry! I think this is the Rust file that should be updated then

auth_token: Option<String>,

@rravenel
Copy link
Author

rravenel commented Sep 3, 2024

.rs updated.

Re-iterating my my bug report: I'm new here, don't know Rust, don't have the doc build env set up.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants