Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reclassify model loading error as server errors #457

Merged
merged 2 commits into from
Oct 1, 2024
Merged

Conversation

oOraph
Copy link
Collaborator

@oOraph oOraph commented Sep 30, 2024

No description provided.

Signed-off-by: Raphael Glon <oOraph@users.noreply.github.com>
Signed-off-by: Raphael Glon <oOraph@users.noreply.github.com>
Comment on lines -122 to -123
except (EnvironmentError, ValueError) as e:
return JSONResponse({"error": str(e)}, status_code=400)

This comment was marked as off-topic.

Copy link
Contributor

@Narsil Narsil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Still I don't feel it's a right move but I won't block anything over this.

@oOraph oOraph merged commit 45907cd into main Oct 1, 2024
2 checks passed
@oOraph oOraph deleted the dev/status_code branch October 1, 2024 08:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants