Overview page modules #532
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
boegel
requested changes
Aug 9, 2023
boegel
requested changes
Aug 9, 2023
| @param filter_fn: Filter function on the ouput. | ||
| @return: | ||
| """ | ||
| lmod = os.getenv('LMOD_CMD') |
There was a problem hiding this comment.
No need to implement in this PR, but we should add some error handling here.
What if $LMOD_CMD is not set (or points to a non-existing path)?
What if the exit code of the Lmod command is non-zero?
| """ | ||
| return data[~np.char.endswith(data, ":") & | ||
| ~np.char.startswith(data, "env/") & | ||
| ~np.char.startswith(data, "cluster/default") |
There was a problem hiding this comment.
This is good enough for now, but a better way to filter these would be to:
- for each module, keep track of which location it was found in, so iterate over output of
module availline by line, and build up a dict withpathas key, list of modules as value; - filter based on
/etc/modulefiles/vsc(which coversenv/*andcluster/*) to discriminate between software module andclustermodules;
Co-authored-by: Kenneth Hoste <kenneth.hoste@ugent.be>
boegel
requested changes
Aug 11, 2023
Co-authored-by: Kenneth Hoste <kenneth.hoste@ugent.be>
|
@boegel |
boegel
requested changes
Aug 14, 2023
| md_file = MdUtils(file_name='module_overview.md', title='Overview of available modules per cluster') | ||
| data = modules_ugent() | ||
| generate_module_table(data, md_file) | ||
| md_file.create_md_file() |
There was a problem hiding this comment.
also print path to file that was created?
Co-authored-by: Kenneth Hoste <kenneth.hoste@ugent.be>
boegel
requested changes
Aug 14, 2023
boegel
approved these changes
Aug 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#553
In this PR: