Skip to content

Commit

Permalink
Code beautify
Browse files Browse the repository at this point in the history
  • Loading branch information
ruff committed Sep 22, 2023
1 parent 610ba5e commit e45520e
Show file tree
Hide file tree
Showing 2 changed files with 24 additions and 14 deletions.
36 changes: 23 additions & 13 deletions src/MimeDb.php
Original file line number Diff line number Diff line change
Expand Up @@ -61,26 +61,32 @@ protected function loadedDatabase(): bool
protected function loadDatabase(): MimeDb
{
$this->mimeDatabase = json_decode(file_get_contents($this->getDbFilename()), true);
$this->mimeDatabase = array_filter($this->mimeDatabase, function ($mimetypeDefinition) {
return isset($mimetypeDefinition['extensions']) && !empty($mimetypeDefinition['extensions']);
});
$this->mimeDatabase = array_filter(
$this->mimeDatabase,
function ($mimetypeDefinition) {
return isset($mimetypeDefinition['extensions']) && !empty($mimetypeDefinition['extensions']);
}
);

return $this;
}

/**
* Find by file extension
*
* @param string $lookuoFileExtension
* @param string $lookuoFileExtension
* @return string|null
*/
public function findType(string $lookuoFileExtension): ?string
{
$this->initializeDatabase();

$foundMimeTypes = array_filter($this->mimeDatabase, function ($mimetypeDefinition) use ($lookuoFileExtension) {
return in_array(ltrim($lookuoFileExtension, "."), $mimetypeDefinition['extensions']);
});
$foundMimeTypes = array_filter(
$this->mimeDatabase,
function ($mimetypeDefinition) use ($lookuoFileExtension) {
return in_array(ltrim($lookuoFileExtension, "."), $mimetypeDefinition['extensions']);
}
);

if (count($foundMimeTypes) === 0) {
return null;
Expand All @@ -93,7 +99,7 @@ public function findType(string $lookuoFileExtension): ?string
* Find by file extension
* This is an alias function for findTyoe
*
* @param string $lookuoFileExtension
* @param string $lookuoFileExtension
* @return string|null
*/
public function findByExtension(string $lookuoFileExtension): ?string
Expand All @@ -104,16 +110,20 @@ public function findByExtension(string $lookuoFileExtension): ?string
/**
* Find by mime type
*
* @param string $lookupMimeType
* @param string $lookupMimeType
* @return string|null
*/
public function findMimeType(string $lookupMimeType): ?string
{
$this->initializeDatabase();

$foundMimeTypes = array_filter($this->mimeDatabase, function ($mimetypeDefinition, $mimetype) use ($lookupMimeType) {
return strcasecmp($mimetype, $lookupMimeType) === 0;
}, ARRAY_FILTER_USE_BOTH);
$foundMimeTypes = array_filter(
$this->mimeDatabase,
function ($mimetypeDefinition, $mimetype) use ($lookupMimeType) {
return strcasecmp($mimetype, $lookupMimeType) === 0;
},
ARRAY_FILTER_USE_BOTH
);

if (reset($foundMimeTypes) === false) {
return null;
Expand All @@ -126,7 +136,7 @@ public function findMimeType(string $lookupMimeType): ?string
* Returns the full-qualified filename where
* the database is located
*
* @return string
* @return string
* @codeCoverageIgnore
*/
private function getDbFilename(): string
Expand Down
2 changes: 1 addition & 1 deletion tests/testcases/MimeDbTest.php
Original file line number Diff line number Diff line change
Expand Up @@ -88,4 +88,4 @@ public function testFindMimeType(): void
$this->assertEquals("mid", $this->mimeDb->findMimeType('audio/midi'));
$this->assertNull($this->mimeDb->findMimeType('unknown/unknown'));
}
}
}

0 comments on commit e45520e

Please sign in to comment.