maint: Use less restrictive package version for instrumentation dependency #196
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MikeGoldsmith
added
the
type: maintenance
MikeGoldsmith
changed the title
MikeGoldsmith
changed the title
kentquirk
approved these changes
May 23, 2024
MikeGoldsmith
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which problem is this PR solving?
The dependency on
opentelemetry-instrumentationis overly restrictive and doesn't allow later minor versions to be used. For example, it's set as~0.43b0but doesn't allow the latest releases0.44b0or0.45b0.This is because the tilde
~version constraint doesn't allow versions that change within the same semver point specified. The version we set is0.43b0, which means it can't go higher than minor release0.43b0and subsequent packages are minor releases. It would allow patch version of the same minor if they were published, eg0.43b0.x.Short description of the changes
opentelemetry-instrumentationpackage version constraint to use the caret^prefix instead, which is equivalent to >= 0.43b0 and < 1.0How to verify that this has the expected result
Later version of opentelemetry-instrumentation package can be used with the distro.