Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

maint: Add nightly tests job #146

Merged
merged 4 commits into from
Jul 11, 2023
Merged

maint: Add nightly tests job #146

merged 4 commits into from
Jul 11, 2023

Conversation

pkanal
Copy link
Contributor

@pkanal pkanal commented Jul 11, 2023 •
edited
Loading

Which problem is this PR solving?

Adds nightly test jobs and upgrades ubuntu and the collector version for smoke tests. It seems like this also fixes the failed smoke test issues we're seeing on main.

Short description of the changes

  • Added nightly workflow to CircleCI config
  • Upgraded Ubuntu for smoke tests
  • Upgraded collector version for smoke tests

How to verify that this has the expected result

  • Nightly build runs tests
  • Not sure how to test the cron job will work exactly before we merge this in, but it is the same as on our other repos so I'm fairly confident it will be the same.

@pkanal pkanal self-assigned this Jul 11, 2023
@pkanal pkanal added type: maintenance The necessary chores to keep the dust off. no-changelog Omit this PR from changelog/release notes. version: no bump A PR with maintenance or doc changes that aren't included in a release. labels Jul 11, 2023
@pkanal pkanal marked this pull request as ready for review July 11, 2023 18:45
@pkanal pkanal requested a review from a team July 11, 2023 18:45
@JamieDanielson JamieDanielson merged commit 37be887 into main Jul 11, 2023
4 checks passed
@JamieDanielson JamieDanielson deleted the purvi/add-nightly-build branch July 11, 2023 22:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JamieDanielson JamieDanielson JamieDanielson approved these changes

Assignees

@pkanal pkanal

Labels
no-changelog Omit this PR from changelog/release notes. type: maintenance The necessary chores to keep the dust off. version: no bump A PR with maintenance or doc changes that aren't included in a release.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add nightly CI build
2 participants
@pkanal @JamieDanielson