generated from honeycombio/.github
-
Notifications
You must be signed in to change notification settings - Fork 6
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
maint: Don’t append OTLP signal paths if already present (#156)
## Which problem is this PR solving? If an HTTP endpoint for traces or metrics already includes the signal path (eg /v1/traces or /v1/metrics), the path is added a second time (eg `http://somewhere.com/v1/traces` becomes `http://somewhere.com/v1/traces/v1/traces`). The path should only be added if it doesn't already exist. - Closes #155 ## Short description of the changes - Update options.get_traces_endpoint and options.get_metrics_endpoint to check if the endpoint already ends with the signal path before adding it - Add tests to verify behaviour ## How to verify that this has the expected result You can now use an endpoint with a signal path and the signal path won't be added twice.
- Loading branch information
1 parent
9f8466f
commit 9bc3f9a
Showing
2 changed files
with
31 additions
and
6 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters