Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extend api capabilities #16

Merged

Conversation

miaucl
Copy link
Contributor

@miaucl miaucl commented Oct 6, 2023

Extend the existing api capabilities

  • locations: add api implementation
  • connections: add missing parameters
  • stationboard: add missing parameters
  • urlli/urlencode: Add "True" flag for correct formatting of lists (ex. via parameter via[]=foo1&via[]=foo2)

No existing functionality should be compromised, only new things have been added.

I will likely extend the home-assistant integration as well as soon as this PR has been merged and a new version got published.

- connections: add all missing parameters
- stationboard: add all missing parameters
- urlencode: Add "True" flag for correct formatting
@miaucl
Copy link
Contributor Author

miaucl commented Oct 9, 2023

Have not yet worked with black linter. Should be fine now ;)

@miaucl
Copy link
Contributor Author

miaucl commented Oct 21, 2023

@fabaff Would it be possible to have a new version with this PR? I would like to extend the home assistant integration as well, but first I need a proper release of this library. :)

@miaucl
Copy link
Contributor Author

miaucl commented Nov 16, 2023

Sorry to ping again :) @fabaff

Copy link
Member

@fabaff fabaff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your work.

@fabaff fabaff merged commit 2077fe0 into home-assistant-ecosystem:master Nov 20, 2023
3 checks passed
@miaucl miaucl deleted the extend-api-capabilities branch November 22, 2023 16:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants