New iconset done properly, one more xcode crash fix

[jessejarvi]

At least this one doesn’t fail just like the previous one :D

[erikng]

Not sure if I'm a fan of that icon, but it's not up to me. :)

On Oct 5, 2016, at 1:15 PM, Jesse J?rvi <notifications@github.commailto:notifications@github.com> wrote:

At least this one doesn't fail just like the previous one :D

---

You can view, comment on, or merge this pull request online at:

#136

Commit Summary

• New icon and compatibility updates
• new icons, crash fix

File Changes

• M MunkiAdmin.xcodeproj/project.pbxprojhttps://github.com/New iconset done properly, one more xcode crash fix #136/files#diff-0 (47)
• M MunkiAdmin.xcodeproj/xcshareddata/xcschemes/MunkiAdmin.xcschemehttps://github.com/New iconset done properly, one more xcode crash fix #136/files#diff-1 (2)
• A MunkiAdmin/AppIcon.icnshttps://github.com/New iconset done properly, one more xcode crash fix #136/files#diff-2 (0)
• M MunkiAdmin/English.lproj/MainMenu.xibhttps://github.com/New iconset done properly, one more xcode crash fix #136/files#diff-3 (113)
• M MunkiAdmin/Graphics/MunkiAdmin.icnshttps://github.com/New iconset done properly, one more xcode crash fix #136/files#diff-4 (0)
• M MunkiAdmin/Graphics/MunkiAdminIcon_32x32.pnghttps://github.com/New iconset done properly, one more xcode crash fix #136/files#diff-5 (0)
• M MunkiAdmin/Graphics/MunkiAdminIcon_32x32@2x.pnghttps://github.com/New iconset done properly, one more xcode crash fix #136/files#diff-6 (0)
• A MunkiAdmin/Images.xcassets/AppIcon.appiconset/Contents.jsonhttps://github.com/New iconset done properly, one more xcode crash fix #136/files#diff-7 (68)
• A MunkiAdmin/Images.xcassets/AppIcon.appiconset/icon_128x128.pnghttps://github.com/New iconset done properly, one more xcode crash fix #136/files#diff-8 (0)
• A MunkiAdmin/Images.xcassets/AppIcon.appiconset/icon_128x128@2x.pnghttps://github.com/New iconset done properly, one more xcode crash fix #136/files#diff-9 (0)
• A MunkiAdmin/Images.xcassets/AppIcon.appiconset/icon_16x16.pnghttps://github.com/New iconset done properly, one more xcode crash fix #136/files#diff-10 (0)
• A MunkiAdmin/Images.xcassets/AppIcon.appiconset/icon_16x16@2x.pnghttps://github.com/New iconset done properly, one more xcode crash fix #136/files#diff-11 (0)
• A MunkiAdmin/Images.xcassets/AppIcon.appiconset/icon_256x256.pnghttps://github.com/New iconset done properly, one more xcode crash fix #136/files#diff-12 (0)
• A MunkiAdmin/Images.xcassets/AppIcon.appiconset/icon_256x256@2x.pnghttps://github.com/New iconset done properly, one more xcode crash fix #136/files#diff-13 (0)
• A MunkiAdmin/Images.xcassets/AppIcon.appiconset/icon_32x32.pnghttps://github.com/New iconset done properly, one more xcode crash fix #136/files#diff-14 (0)
• A MunkiAdmin/Images.xcassets/AppIcon.appiconset/icon_32x32@2x.pnghttps://github.com/New iconset done properly, one more xcode crash fix #136/files#diff-15 (0)
• A MunkiAdmin/Images.xcassets/AppIcon.appiconset/icon_512x512.pnghttps://github.com/New iconset done properly, one more xcode crash fix #136/files#diff-16 (0)
• A MunkiAdmin/Images.xcassets/AppIcon.appiconset/icon_512x512@2x.pnghttps://github.com/New iconset done properly, one more xcode crash fix #136/files#diff-17 (0)
• M MunkiAdmin/MunkiAdmin-Info.plisthttps://github.com/New iconset done properly, one more xcode crash fix #136/files#diff-18 (2)
• M Podfile.lockhttps://github.com/New iconset done properly, one more xcode crash fix #136/files#diff-19 (2)
• M Pods/Manifest.lockhttps://github.com/New iconset done properly, one more xcode crash fix #136/files#diff-20 (2)
• M Pods/Pods.xcodeproj/project.pbxprojhttps://github.com/New iconset done properly, one more xcode crash fix #136/files#diff-21 (212)
• M Pods/Target Support Files/Pods-MunkiAdmin/Pods-MunkiAdmin-acknowledgements.plisthttps://github.com/New iconset done properly, one more xcode crash fix #136/files#diff-22 (8)
• M Pods/Target Support Files/Pods-MunkiAdmin/Pods-MunkiAdmin.debug.xcconfighttps://github.com/New iconset done properly, one more xcode crash fix #136/files#diff-23 (1)
• M Pods/Target Support Files/Pods-MunkiAdmin/Pods-MunkiAdmin.release.xcconfighttps://github.com/New iconset done properly, one more xcode crash fix #136/files#diff-24 (1)

Patch Links:

• https://github.com/hjuutilainen/munkiadmin/pull/136.patch
• https://github.com/hjuutilainen/munkiadmin/pull/136.diff

You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHubhttps://github.com//pull/136, or mute the threadhttps://github.com/notifications/unsubscribe-auth/AFa_GN6NeGzvkE9BPVkjIcqhg2cT4Fviks5qxAVNgaJpZM4KPPN_.

[jessejarvi]

The icon is designed to look like the Managed Software Center but with a blueprint design to make it seem that this software is indeed used to manage Munki - instead of a brown monkey picture which isn't the munki logo. @hjuutilainen , what do you think?

[bochoven]

I like the previous icon better.

[apettinen]

I like the previous icon better; the new one is basically the Managed Software Center icon in blue color.

The previous icon is more distinguishable from the App Store and MSC icons, which at least I find a good thing.

Plus I like the monkey pun.