Skip to content

Commit

Permalink
In bootstrap_java_library, use the javac from the exec/tool JDK, no…
Browse files Browse the repository at this point in the history
…t the target JDK

The JDK is being used here as a tool that runs during the build (for javac), so it should be in the exec configuration.

See also unknown commit

PiperOrigin-RevId: 611588284
Change-Id: Iaaa9b6d92e03546ece3f1e833a4a532fada2e583
  • Loading branch information
cushon authored and copybara-github committed Feb 29, 2024
1 parent a941db1 commit 4bb9b54
Showing 1 changed file with 1 addition and 0 deletions.
1 change: 1 addition & 0 deletions tools/build_rules/java_rules_skylark.bzl
Original file line number Diff line number Diff line change
Expand Up @@ -216,6 +216,7 @@ java_library_attrs = {
"_jdk": attr.label(
default = Label("@bazel_tools//tools/jdk:current_java_runtime"),
providers = [java_common.JavaRuntimeInfo],
cfg = "exec",
),
"data": attr.label_list(allow_files = True),
"resources": attr.label_list(allow_files = True),
Expand Down

0 comments on commit 4bb9b54

Please sign in to comment.