Skip to content

Commit

Permalink
Always re-enable blocking mode
Browse files Browse the repository at this point in the history
Fixes a logic error whereby blocking mode was only re-enabled in the
RRemoteFactory::checkConnection() method if the call to recv()
succeeded.
  • Loading branch information
Colin Ward authored and hitman-codehq committed Jul 9, 2024
1 parent 5c0d288 commit e3b349b
Showing 1 changed file with 2 additions and 6 deletions.
8 changes: 2 additions & 6 deletions RemoteFactory.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -137,7 +137,6 @@ void RRemoteFactory::close()
* @return KErrNone if successful, otherwise one of the errors returned by RRemoteFactory::openRemote()
*/

// TODO: CAW - Move this stuff into RSocket?
int RRemoteFactory::checkConnection()
{
int retVal = KErrNone;
Expand Down Expand Up @@ -182,12 +181,9 @@ int RRemoteFactory::checkConnection()
char buffer[1];
result = recv(m_socket.m_socket, buffer, 1, 0);

if (result != -1)
if (fcntl(m_socket.m_socket, F_SETFL, flags) == -1)
{
if (fcntl(m_socket.m_socket, F_SETFL, flags) == -1)
{
result = -1;
}
result = -1;
}
}
}
Expand Down

0 comments on commit e3b349b

Please sign in to comment.