Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: validate ts client predicates before registering #639

Merged
merged 2 commits into from
Aug 15, 2024

Conversation

rafaelcr
Copy link
Collaborator

Changes the TS client server code so it now checks if a predicate UUID already exists and is active in the target Chainhook node. If it is, it reuses it. If it isn't it removes it and registers again.

Copy link
Contributor

@csgui csgui left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code LGTM. Just a small comment on a log info.

components/client/typescript/src/server.ts Outdated Show resolved Hide resolved
@rafaelcr rafaelcr merged commit 2d08f72 into develop Aug 15, 2024
7 checks passed
@rafaelcr rafaelcr deleted the fix/validate-client-predicates branch August 15, 2024 14:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants