Namada gas estimation #32
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sug0
requested changes
Jun 11, 2024
Comment on lines
76
to
78
| // Estimate the fee with dry-run | ||
| let (fee_token, gas_limit, fee_amount) = | ||
| self.estimate_fee(tx.clone(), &tx_args, signing_data)?; |
There was a problem hiding this comment.
Not all nodes should be required to enable dry running txs via their exposed RPC servers, since these may pose a DoS vector. estimate_fee should be expected to fail with a nonexistent RPC error, at which point we could fallback to another gas estimation mechanism (e.g. median values that have been benchmarked during a release).
There was a problem hiding this comment.
That makes sense. I'll fix it.
sug0
reviewed
Jun 19, 2024
sug0
approved these changes
Jun 21, 2024
yito88
added a commit
that referenced
this pull request
Jul 1, 2024
* gas estimation * add error * adjust gas * fix script * use the default gas setting when gas estimation failure
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #30