Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add catchable failure decoders for more encodings: #175

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

mrijkeboer
Copy link

@mrijkeboer mrijkeboer commented Apr 21, 2017

This adds the following decoders:

  • decodeUtf16LE'
  • decodeUtf16BE'
  • decodeUtf32LE'
  • decodeUtf32BE'

- decodeUtf16LE'
- decodeUtf16BE'
- decodeUtf32LE'
- decodeUtf32BE'
@bos
Copy link
Contributor

bos commented Aug 8, 2017

These seem like good ideas, but I have two observations.

The names aren't exactly self-documenting :-)

The implementations seem a bit unnatural. Basically if you're round-tripping through unsafePerformIO . try . evaluate, maybe the underlying primitives have the wrong return types?

@mrijkeboer
Copy link
Author

The code is based on the already provided decodeUtf8' function. I tried to keep it as consistent with the existing code as possible.

@Bodigrim Bodigrim marked this pull request as draft February 28, 2023 18:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants