Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

eliminate for loops and use np.sum #22

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

maldil
Copy link

@maldil maldil commented Jul 1, 2022

Hi Maintainers of this repo,

Thank you very much for your excellent work in Chemml,

I am new to this repository.
I am a researcher studying the best practices of evolving data science codes. According to our findings, migration of loop-based computations is a common evolution practice among the developers since it increases performance and code quality. I observed the code in this PR where it could make better use of functions from NumPy and eliminate inefficient loops.

This PR is a minor contribution compared to all the hard work that you have done in this repo. However, I am hoping that it will enhance code quality and, hopefully, performance.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant