Allow header instances in message delivery methods #281
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If you had multiple headers with the same name and different values, it was impossible to provide them as a one dimensional hash. This patch changes `Header::listFromArray()` so that it will accept instances of `Header` rather than assuming the argument is a map. The side effect is that users can supply a list of `Header` instances, thereby enabling multiple headers with the same name. Additionally, this patch rejects array members with an empty string. Previously, an assertion error would have been thrown in dev, but silently and erroneously passed to the server in prod.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If you had multiple headers with the same name and different values, it was impossible to provide them as a one dimensional hash.
This patch changes
Header::listFromArray()so that it will accept instances ofHeaderrather than assuming the argument is a map. The side effect is that users can supply a list ofHeaderinstances, thereby enabling multiple headers with the same name.Additionally, this patch rejects array members with an empty string. Previously, an assertion error would have been thrown in dev, but silently and erroneously passed to the server in prod.