Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(design): create skeleton mixin #1354

Merged
merged 2 commits into from
Mar 15, 2021
Merged

feat(design): create skeleton mixin #1354

merged 2 commits into from
Mar 15, 2021

Conversation

xelaint
Copy link
Member

@xelaint xelaint commented Mar 12, 2021

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[x] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Other... Please describe:

What is the current behavior?

Part of: #763

What is the new behavior?

Does this PR introduce a breaking change?

[ ] Yes
[ ] No

Other information

@xelaint xelaint requested a review from a team as a code owner March 12, 2021 21:33
@damienwebdev
Copy link
Member

@xelaint minor linting issues, but otherwise, LGTM.

@xelaint
Copy link
Member Author

xelaint commented Mar 15, 2021

@xelaint minor linting issues, but otherwise, LGTM.

fixed linting

Copy link
Member

@damienwebdev damienwebdev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@damienwebdev damienwebdev merged commit 11ad6ab into develop Mar 15, 2021
@damienwebdev damienwebdev deleted the skeleton-mixin branch March 15, 2021 21:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants