Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(design): removed fixed and side mode and added fixed input property #1000

Closed
wants to merge 3 commits into from
Closed

feat(design): removed fixed and side mode and added fixed input property #1000

wants to merge 3 commits into from

Conversation

Nolan-Arnold
Copy link
Contributor

@Nolan-Arnold Nolan-Arnold commented Jul 14, 2020 •
edited by xelaint
Loading

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[x ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Other... Please describe:

What is the current behavior?

Part of: #763

What is the new behavior?

Does this PR introduce a breaking change?

[ ] Yes
[ x] No

Other information

@Nolan-Arnold Nolan-Arnold requested a review from a team as a code owner July 14, 2020 17:00
@xelaint
Copy link
Member

xelaint commented Aug 17, 2020 •
edited
Loading

@Nolan-Arnold Is there any functionality for over or are you doing that in another PR?

@xelaint xelaint added the package: design @daffodil/design label Aug 18, 2020
@Nolan-Arnold Nolan-Arnold requested review from a team as code owners August 24, 2020 13:33
@Nolan-Arnold Nolan-Arnold force-pushed the fix-mode branch 2 times, most recently from 213fd68 to 49c925c Compare January 12, 2021 20:43
@Nolan-Arnold
feat(design): removed fixed and side mode and added fixed input property
2415f2e 
Signed-off-by: Nolan Arnold <nolan.arnold@gmail.com>
@Nolan-Arnold
fix(sidebar): fixed tests for sidebar and updated implementations
49c925c 
Signed-off-by: Nolan Arnold <nolan.arnold@gmail.com>
@Nolan-Arnold
Copy link
Contributor Author

@xelaint All of your previous comments were resolved in 49c925c.

@xelaint xelaint self-requested a review January 19, 2021 19:48
xelaint
xelaint approved these changes Jan 19, 2021
View reviewed changes
Copy link
Member

@xelaint xelaint left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@xelaint
Copy link
Member

xelaint commented Feb 4, 2021

@damienwebdev Just noticed in this issue #763, we defined the sidebar inputs as static | over | shift.

@damienwebdev damienwebdev mentioned this pull request Jun 21, 2021
Merged
3 tasks
@xelaint xelaint closed this Jul 9, 2021
@damienwebdev damienwebdev deleted the fix-mode branch July 29, 2021 17:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xelaint xelaint xelaint approved these changes

Assignees

@damienwebdev damienwebdev

@xelaint xelaint

@Nolan-Arnold Nolan-Arnold

Labels
package: design @daffodil/design
Projects
The Design Library
Status: Done
Milestone
v0.8.0 - The Design Package V2
Development

Successfully merging this pull request may close these issues.
3 participants
@Nolan-Arnold @xelaint @damienwebdev