fix program shutdown #29
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
neriumrevolta
previously approved these changes
Aug 2, 2023
hopeyen
force-pushed
the
hope/fix-shutdown
branch
from
19f06d0
to
f11da13
Compare
neriumrevolta
approved these changes
Aug 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When running the program and press
ctrl+c, the HTTP server stops with graceful shutdown, but the rest of the program stalls and does not ever return. In this PR we make a quick fix to remove the additional graceful shutdown soctrl+cis effective over all.Issue link (if applicable)
Resolves #22
Later we can ensure shutdown processes are safe at #28
Checklist