This repository has been archived by the owner on Jul 20, 2023. It is now read-only.
Fix tests #205
Merged
Fix tests #205
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hopeyen
approved these changes
Jul 13, 2023
neriumrevolta
force-pushed
the
petko/fix-tests-1
branch
from
b0f854c
to
fde6557
Compare
hopeyen
approved these changes
Jul 13, 2023
hopeyen
reviewed
Jul 13, 2023
There was a problem hiding this comment.
small q: Should timestamp always be used for dummyMsg or should it be prioritizing config.nonce?
https://github.com/graphops/poi-radio/pull/205/files#diff-3776cef2cdbf9b3ecc33139b48c317ad92742dd462cb52f5c12c112a36180ce3R133
hopeyen
approved these changes
Jul 13, 2023
|
For the use case of the current dummy message (just to test invalid payload) I think it doesn't make a difference, but it will be more consistent if it's the same as the regular payload I agree |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.