feat(starter-update): helmfile restruct, cleanup #93
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cjorge-graphops
requested changes
Apr 22, 2024
docs/launchpad/quick-start.md
Outdated
| @@ -78,14 +78,28 @@ Remember that each cluster might have specific setup steps or requirements, espe | |||
| - [x] We have installed all the tooling dependencies on our local machine, which will be used to control the cluster | |||
| - [ ] Next: Copy `sample.helmfile.yaml` to `helmfile.yaml` and edit it to customize and deploy Namespaces on the Kubernetes cluster | |||
There was a problem hiding this comment.
Here maybe we want to convey that with this structure one ought to customize helmfile.yaml to "select" which namespaces to import, and then customize said namespaces to add values for each (in case it's needed)
|
blocked by merging of https://github.com/graphops/launchpad-namespaces/pull/628/files |
cjorge-graphops
approved these changes
Apr 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.