Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update graphcast docs #73

Merged
merged 4 commits into from
Sep 11, 2023
Merged

Conversation

neriumrevolta
Copy link
Contributor

@neriumrevolta neriumrevolta commented Aug 29, 2023

  • renamed one-shot-cli to graphcast-cli and refactor commands to reflect recent updates
  • Added section for indexing-status subcommand
  • rename VersionUpgradeMessage to UpgradeIntentMessage
  • Added RATELIMIT_THRESHOLD config var to variables table
  • Added upgradeIntentMessages query to graphql queries section

Copy link
Contributor

@hopeyen hopeyen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Generally looks good!


## Introduction

The Graphcast CLI enables sending one-off messages. Currently, its default behaviour is to construct and send a message of type `UpgradeIntentMessage`, which is used for the [Subgraph Upgrade Pre-sync feature](https://docs.graphops.xyz/graphcast/design-principles#subgraph-upgrade-pre-sync) of Subgraph Radio.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is no default behavior anymore, subcommand is required.

It would be good to explain how the 2 current subcmd fit together for the presyncing feature

docs/graphcast/radios/graphcast-cli.md Show resolved Hide resolved

The Graphcast CLI code is very extensible and could be altered to send any kind of Graphcast-compatible message to the network.

## Run with Docker
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perhaps include a paragraph on what to expect when they run this command (potential logs and summaries)

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe we can have a more dedicated page for the presyncing feature overall, with concise description on the ideal flow and interaction of components. like the usage guide you mentioned writing

docs/graphcast/radios/graphcast-cli.md Outdated Show resolved Hide resolved
sidebar_position: 3
---

# Subgraph upgrade pre-sync feature
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

include a workflow diagram here; you can edit from the existing one graphops/subgraph-radio#6

@neriumrevolta neriumrevolta requested review from hopeyen and removed request for hopeyen September 8, 2023 11:27
@chriswessels chriswessels merged commit 8cdd476 into main Sep 11, 2023
2 checks passed
@chriswessels chriswessels deleted the petko/update-graphcast-docs branch September 11, 2023 09:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants