Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: update general graphcast docs, add a page for 3la radio #63

Merged
merged 1 commit into from
Jul 1, 2023

Conversation

hopeyen
Copy link
Contributor

@hopeyen hopeyen commented Jun 29, 2023

Update sections

  • Design principle
  • Graphcast intro
  • SDK intro - a few subsections added
  • POI new user configs
  • 3LA page under the radio category

Copy link
Contributor

@neriumrevolta neriumrevolta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Amazing work 🚀 just some formatting & rewording suggestions

docs/graphcast/design-principles.md Outdated Show resolved Hide resolved
docs/graphcast/design-principles.md Outdated Show resolved Hide resolved
docs/graphcast/design-principles.md Outdated Show resolved Hide resolved
docs/graphcast/design-principles.md Show resolved Hide resolved
docs/graphcast/design-principles.md Outdated Show resolved Hide resolved
docs/graphcast/radios/poi-radio.md Show resolved Hide resolved
docs/graphcast/radios/poi-radio.md Outdated Show resolved Hide resolved
docs/graphcast/radios/poi-radio.md Outdated Show resolved Hide resolved
docs/graphcast/sdk/intro.md Show resolved Hide resolved
docs/graphcast/sdk/intro.md Show resolved Hide resolved
@hopeyen
Copy link
Contributor Author

hopeyen commented Jun 30, 2023

thanks for the review. I resolved some of the suggestions but left some personal preferences on the docs (mostly on the capitalization of phrases); personally would rather not make those commit changes, but feel free to do so when you update the docs. will squash before merge

@neriumrevolta neriumrevolta self-requested a review June 30, 2023 21:19
@neriumrevolta
Copy link
Contributor

thanks for the review. I resolved some of the suggestions but left some personal preferences on the docs (mostly on the capitalization of phrases); personally would rather not make those commit changes, but feel free to do so when you update the docs. will squash before merge

sgtm

@hopeyen hopeyen merged commit 143f3af into main Jul 1, 2023
1 check passed
@hopeyen hopeyen deleted the hope/sdk-poi-3la-updates branch July 1, 2023 00:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants