-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci: migrate push/pr pipeline to GHA #842
Open
roobre
wants to merge
4
commits into
main
Choose a base branch
from
gha-push-pr
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,81 @@ | ||
name: Push/PR | ||
|
||
on: | ||
pull_request: {} | ||
push: | ||
branches: | ||
- main | ||
|
||
jobs: | ||
deps: | ||
name: Check dependencies | ||
runs-on: ubuntu-latest | ||
steps: | ||
- uses: actions/checkout@v4 | ||
- uses: actions/setup-go@v5 | ||
with: | ||
go-version-file: go.mod | ||
- name: Ensure deps are clean | ||
run: | | ||
make deps | ||
./scripts/enforce-clean | ||
|
||
build: | ||
name: Build | ||
runs-on: ubuntu-latest | ||
steps: | ||
- uses: actions/checkout@v4 | ||
with: | ||
fetch-depth: 0 # Needed for version script to work. | ||
- uses: actions/setup-go@v5 | ||
with: | ||
go-version-file: go.mod | ||
- name: Build | ||
run: | | ||
make build | ||
- uses: docker/setup-qemu-action@v3 | ||
- uses: docker/setup-buildx-action@v3 | ||
- name: Build container | ||
uses: docker/build-push-action@v6 | ||
with: | ||
push: false | ||
platforms: linux/amd64,linux/arm64 | ||
# Needed for this action to use local context incl. binaries built in the previous step. | ||
# https://github.com/docker/build-push-action?tab=readme-ov-file#path-context | ||
# TODO: Make docker build self-contained. | ||
context: . | ||
tags: ci.local/${{ github.repository }} | ||
|
||
test: | ||
name: Test | ||
runs-on: ubuntu-latest | ||
steps: | ||
- uses: actions/checkout@v4 | ||
- uses: actions/setup-go@v5 | ||
with: | ||
go-version-file: go.mod | ||
- name: Test | ||
run: | | ||
make build-xk6-linux-amd64 # Tests require a valid k6 binary in dist/k6 | ||
make test | ||
|
||
lint: | ||
name: Lint | ||
runs-on: ubuntu-latest | ||
steps: | ||
- uses: actions/checkout@v4 | ||
# Get golangci-lint version that `make lint` uses. | ||
- name: Retrieve golangci-lint version | ||
id: version | ||
run: |- | ||
echo "golangci=$(make golangci-lint-version)" >> $GITHUB_OUTPUT | ||
# Use the golangci-lint action, which provides Github-specific features such as diff annotations. | ||
- name: Run golangi-lint | ||
uses: golangci/golangci-lint-action@v6 | ||
with: | ||
version: ${{ steps.version.outputs.golangci }} | ||
args: --timeout=5m # 1m is not enough, experimentally. | ||
only-new-issues: true | ||
- name: Run the rest of the linters | ||
run: |- | ||
make lint GOLANGCI_LINT=/bin/true |
File renamed without changes.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If this is needed, it means there's a missing dependency in the makefile.
I vaguely remember adding that...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it is there on another repo (perhaps the runner)? But yep, one test failed cryptically without this (and I am running legit
make test
this time, notgo test
).