Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds rideshare memory leak #2641

Open
wants to merge 8 commits into
base: main
Choose a base branch
from
Open

Adds rideshare memory leak #2641

wants to merge 8 commits into from

Conversation

Rperry2174
Copy link
Contributor

@Rperry2174 Rperry2174 commented Nov 6, 2023

Adding memory for example purposes
image

builds off of #2640 and #2632 and #2610 but makes the leak more visible

@Rperry2174 Rperry2174 requested a review from a team as a code owner November 6, 2023 01:20
Copy link
Contributor

@cyriltovena cyriltovena left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@bryanhuhta bryanhuhta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍 added one note on adjusting parameters

Comment on lines +9 to +10
- PARAMETERS_POOL_SIZE=10000
- PARAMETERS_POOL_BUFFER_SIZE_KB=10000
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Adjusting the sizes here will work when running locally, but in order to get these to reflect in sedemo, you'll need to update them here. There's additional knobs to tune there as well. The memory limit is 64Mi per pod, so using sizes this big would OOM those pods right away.

Of course, if this is just intended to be shown with a local version of the rideshare demo then adjusting these settings will but 👌

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants