fix(helm): Fixed migrate not being consistent in name for hooks #4968
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This makes it so that the yaml being created for the migrate job is consistent when `useHook` is `true` or `false`. At the moment if use hook is false, the the name on the yaml and in the metadata match. But if use hook is true then the name on the object itself is different from the one in the metadata.
|
|
|
This pull request has been automatically marked as stale because it has not had activity in the last 30 days. It will be closed in 30 days if no further activity occurs. Please feel free to give a status update now, ping for review, or re-open when it's ready. Thank you for your contributions! |
github-actions
bot
added
the
pr:stale
|
Just looking for feedback still, not stale |
github-actions
bot
removed
the
pr:stale
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does
This makes it so that the yaml being created for the migrate job is consistent when
useHookistrueorfalse. At the moment if use hook is false, the the name on the yaml and in the metadata match. But if use hook is true then the name on the object itself is different from the one in the metadata.Which issue(s) this PR closes
Didn't open an issue for this since it's minor.
Basically I have an "infra" repo that generates the yaml from several helm charts and version controls the generated yaml. It's an easy way to make sure that a chart update doesn't absolutely clobber something and makes it very easy to see whats actually getting pushed out to the kube cluster before actually applying it.
Because of the way this "metadata.name" field was being generated, it would result in the file being changed each time the yaml for the repository was generated which made for some odd diffs when something completely different may have changed.
Checklist
pr:no public docsPR label added if not required)release:). These labels dictate how your PR willshow up in the autogenerated release notes.
Not aware of any tests for this specifically in this repo that I can see, or documentation around this specific behavior.