Skip to content

Commit

Permalink
More test fixes
Browse files Browse the repository at this point in the history
Signed-off-by: Pete Wall <pete.wall@grafana.com>
  • Loading branch information
petewall committed Oct 4, 2024
1 parent 2169f94 commit 8e555ed
Show file tree
Hide file tree
Showing 6 changed files with 6 additions and 17 deletions.
3 changes: 1 addition & 2 deletions charts/k8s-monitoring/templates/destinations/_helpers.tpl
Original file line number Diff line number Diff line change
Expand Up @@ -95,8 +95,7 @@ remote.kubernetes.secret.{{ include "helper.alloy_name" .destination.name }}.dat
{{/*Determines if the destination will reference a Kubernetes secret*/}}
{{/*Inputs: . (destination definition)*/}}
{{- define "destinations.secret.uses_k8s_secret" -}}
{{- if eq (include "destinations.auth.type" .) "none" }}false
{{- else if eq (include "destinations.secret.type" .) "embedded" -}}false
{{- if eq (include "destinations.secret.type" .) "embedded" -}}false
{{- else -}}
{{- $hasSecretDefined := false }}
{{- $secrets := include (printf "destinations.%s.secrets" .type) . | fromYamlArray }}
Expand Down
Original file line number Diff line number Diff line change
@@ -1,9 +1,7 @@
---
tests:
- env:
PROMETHEUS_URL: https://prometheus-server.prometheus.svc:9090/api/v1/query
PROMETHEUS_USER: promuser
PROMETHEUS_PASS: prometheuspassword
PROMETHEUS_URL: http://prometheus-server.prometheus.svc:9090/api/v1/query
LOKI_URL: http://loki.loki.svc:3100/loki/api/v1/query
LOKI_TENANTID: 1
LOKI_USER: loki
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -6,13 +6,6 @@ destinations:
- name: localPrometheus
type: prometheus
url: https://prometheus-server.prometheus.svc:9090/api/v1/write
tenantId: "1"
auth:
type: basic
username: promuser
password: prometheuspassword
tls:
insecureSkipVerify: true
- name: localLoki
type: loki
url: http://loki.loki.svc:3100/loki/api/v1/push
Expand Down
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
---
alloy:
enabled: false
pyroscope:
extraArgs:
"auth.multitenancy-enabled": true
#pyroscope:

Check failure on line 4 in charts/k8s-monitoring/tests/integration/profiling/pyroscope.yaml

View workflow job for this annotation

GitHub Actions / runner / yamllint

[yamllint] reported by reviewdog 🐶 [warning] missing starting space in comment (comments) Raw Output: ./charts/k8s-monitoring/tests/integration/profiling/pyroscope.yaml:4:2: [warning] missing starting space in comment (comments)
# extraArgs:
# "auth.multitenancy-enabled": true
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
---
tests:
- env:
PYROSCOPE_URL: http://pyroscope.pyroscope.svc:4040
PROFILECLI_URL: http://pyroscope.pyroscope.svc:4040
queries:
- query: '{cluster="ci-test-cluster"}'
type: pyroql
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,6 @@ destinations:
- name: pyro
type: pyroscope
url: http://pyroscope.pyroscope.svc:4040
tenantId: 1

profiling:
enabled: true
Expand Down

0 comments on commit 8e555ed

Please sign in to comment.